Increased detectArchitecture() timeout #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout for detechArchitecture() is sometimes too low when devices are on wifi network connections and even sometimes over USB. The command can take up to 3 seconds to execute and return. Currently the timeout is set to 1000 ms and setting it to 5000 ms seems to be a good compromise.
Codecov Report
@@ Coverage Diff @@
## master #965 +/- ##
==========================================
- Coverage 68.11% 68.00% -0.11%
==========================================
Files 21 21
Lines 1866 1866
==========================================
- Hits 1271 1269 -2
- Misses 595 597 +2
Continue to review full report at Codecov.
|
3 tasks
breautek
approved these changes
May 22, 2020
|
Thank you for your contribution. I'd like to see one other PMC member vote positive before I merge. |
timbru31
approved these changes
May 22, 2020
|
Thanks Tim! And thank you @GimpArm for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout for detectArchitecture() is sometimes too low when devices are on wifi network connections and even sometimes over USB. The command can take up to 3 seconds to execute and return. Currently the timeout is set to 1000 ms and setting it to 5000 ms seems to be a good compromise.
Platforms affected
Android
Motivation and Context
#963
Description
Increased the detectArchitecture() method timeout from 1000 ms to 5000 ms
Testing
Changing the timeout does not affect and unit tests.
Checklist
(platform)if this change only applies to one platform (e.g.(android))